Skip to content

Improve skill for using dart_skills_lint#86

Merged
reidbaker merged 2 commits intoflutter:mainfrom
reidbaker:r-real-world-integration-feedback-for-adding-lint
Apr 16, 2026
Merged

Improve skill for using dart_skills_lint#86
reidbaker merged 2 commits intoflutter:mainfrom
reidbaker:r-real-world-integration-feedback-for-adding-lint

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

Add information for initial setup based on real world integrations into flutter/flutter and devtools
Add package skills to evaluation set

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

…o flutter/flutter and devtools, also add package skills to evaluation set
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dart_skills_lint configuration and significantly expands the SKILL.md documentation, adding a detailed test example with logging and a new section on integration best practices. Feedback highlights a configuration error where directory-specific rules must be nested under a 'rules' key to be recognized. Additionally, it is suggested to clarify that generated baseline files require an explicit reference in the YAML configuration to be active.

Comment thread tool/dart_skills_lint/dart_skills_lint.yaml Outdated
Comment thread tool/dart_skills_lint/skills/dart-skills-lint-validation/SKILL.md
@reidbaker reidbaker merged commit 4306877 into flutter:main Apr 16, 2026
7 checks passed
@reidbaker reidbaker deleted the r-real-world-integration-feedback-for-adding-lint branch April 16, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant