Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the Table of Contents (ToC) and page navigation by integrating stepper titles into the active observer and introducing a showPageTitle notifier to manage visibility. Feedback includes simplifying a boolean assignment for better readability, correcting a logic error where the page heading was set to the current step instead of the next step during stepper transitions, and resolving variable shadowing in the ValueListenableBuilder for improved code clarity.
Collaborator
|
Visit the preview URL for this PR (updated for commit 9954c79): https://flutter-docs-prod--pr13311-fix-pagenav-header-for-tuto-8ckgj3kh.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13188
Special handling for steppers that always shows the title of the currently open step, independent of scrolling - only when scrolling up the page title is shown instead.