-
Notifications
You must be signed in to change notification settings - Fork 0
WASM compatibility: drop dart:io from import graph (pana 160/160) #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eeead13
fix: detect platform via defaultTargetPlatform to drop dart:io
anilcancakir 9464eb9
fix: resolve absolute-path images via conditional import to drop dart:io
anilcancakir ad114f4
ci: assert is:wasm-ready in the Lint & Test job
anilcancakir be488d4
docs(changelog): note WASM compatibility (pana 160/160)
anilcancakir 8e511e0
ci: make wasm-ready assertion log tags + exit explicitly
anilcancakir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:flutter/widgets.dart' show FileImage, ImageProvider; | ||
|
|
||
| /// Returns a [FileImage] for the given filesystem [path]. | ||
| /// | ||
| /// This arm is compiled only on native VM targets where dart:io File | ||
| /// is available. The stub arm in file_image_stub.dart is selected for | ||
| /// web and WASM targets via the conditional import in background_parser.dart. | ||
| ImageProvider<Object>? fileImageProvider(String path) => FileImage(File(path)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import 'package:flutter/widgets.dart' show ImageProvider; | ||
|
|
||
| /// Returns null on web/WASM targets where the `File` API is unavailable. | ||
| /// | ||
| /// The io arm in file_image_io.dart is selected instead on native VM targets | ||
| /// via the conditional import in background_parser.dart. | ||
| ImageProvider<Object>? fileImageProvider(String path) => null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8e511e0: the step now prints the present tags and exits with an explicit integer (
sys.exit(0 if ok else 1)), so a failure shows which tags were found.