ssa: handle Jobs with TTL during health check #1085
Merged
+326
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
enhancement
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
matheuscscp
approved these changes
Feb 3, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Great improvement and fix for helm-controller kstatus poller 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job with TTL can be deleted after completion during health checking. This PR allows callers to specify which Jobs have TTL enabled so that
ssa.Waitwill not report not found errors for these.Changes:
ExtractJobsWithTTLhelper function tossa/utilspackageJobsWithTTLfield toWaitOptionsand updated error handling to treatNotFoundStatusfor Jobs with TTL as success