Require Holmes artifact schema versions

[flyingrobots]

Summary

• Fixes the Codex P2 finding from merged PR Add Holmes law evidence validation gate #536: present Holmes law evidence artifact references now require artifact-local schemaVersion values.
• Adds RED/GREEN regression coverage for missing schema versions on required artifacts and present optional artifacts.
• Updates clean Holmes validation fixtures to set explicit artifact schema versions and keeps malformed/unsupported version handling fail-closed.

Tests

• cargo test -p wesley-holmes
• git diff --check
• pnpm run preflight
• pre-push Rust product preflight

Fixes follow-up for #536 Codex review thread: #536 (comment)

[coderabbitai]

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 51 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5a526e2e-e340-45b0-931d-f7f299b592d9

📥 Commits

Reviewing files that changed from the base of the PR and between 8feb49d and 7f26722.

📒 Files selected for processing (3)

• CHANGELOG.md
• crates/wesley-holmes/src/domain/evidence.rs
• crates/wesley-holmes/tests/foundation.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch holmes-artifact-schema-version-followup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔍 The Case of Pull Request #537

Plain-English Readout

• Holmes (evidence investigation): Holmes says this change looks ready to ship.
• Watson (independent verification): Watson found verification concerns. Most important concern: No evidence citations were available for trust analysis.
• Moriarty (trend forecast): Moriarty does not have enough historical data yet to forecast readiness.

Suggested next actions

1. Resolve Watson’s verification concerns before trusting the Holmes verdict as final.

📚 Glossary (what the Holmes terms mean)

• HOLMES: Wesley’s main evidence investigation. It decides whether the cited proof is strong enough to justify shipping this commit.
• WATSON: An independent verification pass. It checks Holmes’s citations and score math instead of trusting them blindly.
• MORIARTY: A readiness forecast over time. It is advisory trend analysis, not the release gate itself.
• Schema coverage score (SCS): How much of the schema has direct supporting evidence across generated artifacts and cited proof.
• Test confidence index (TCI): How much test evidence exists for constraints, policies, relationships, and operations.
• Migration risk index (MRI): How risky the schema change is to roll out. Lower is better.
• Evidence trust: Whether the report is backed by exact citations, whole-file citations, or coarse references. Weak trust means the claim may be directionally right but not specific enough to trust blindly.
• Citation quality: A count of exact line-span citations versus whole-file or coarse references.
• ELEMENTARY: Ready to ship based on the current evidence.
• REQUIRES INVESTIGATION: More work or review is needed before shipping.
• YOU SHALL NOT PASS: Do not ship this change in its current state.

---

🕵️ SHA-lock HOLMES full report (click to expand)

🕵️ SHA-lock HOLMES Investigation

• Generated: 2026-01-01T00:00:00.000Z
• Commit SHA: 5912604
• Bundle Version: 2.0.0

⚠️ Evidence valid only for commit 5912604

🔍 Executive Deduction

"Watson, after careful examination of the evidence, I deduce..."

Weighted Completion: ██████████ 95.0%
Scores: SCS 95.0% · TCI 90.0% · MRI 10.0%
Verification Status: 2 claims verified
Citation Quality: 2 exact · 0 whole-file · 0 coarse
Evidence Trust: strong
Ship Verdict: ELEMENTARY

🧩 SCS Breakdown

Component	Score	Coverage
Sql	100.0%	1.00/1.00
Types	100.0%	1.00/1.00
Validation	100.0%	1.00/1.00
Tests	100.0%	1.00/1.00

🧪 TCI Breakdown

Component	Score	Coverage	Note
Unit Constraints	100.0%	1/1	N/A
Unit Rls	100.0%	1/1	N/A
Integration Relations	100.0%	1/1	N/A
E2e Ops	90.0%	9/10	fixture

⚠️ MRI Breakdown

Component	Risk Share	Points	Count
Drops	0.0%	0	0
Renames Without Uid	0.0%	0	0
Add Not Null Without Default	100.0%	1	1
Non Concurrent Indexes	0.0%	0	0

📊 The Weight of Evidence

"Observe, Watson, how not all features carry equal importance..."

Element	Weight	Status	Evidence	Strength	Deduction
schema	5	✅ Exact SQL & tests	test/fixtures/examples/.wesley-cache/shipme-fixture/tests.sql:1-1@5912604	exact	Elementary!

🚪 Security & Performance Gates

"Elementary security measures, Watson..."

Gate	Status	Evidence	Holmes's Ruling
Migration Risk	✅	MRI: 10.0%	"Trivial risk"
Test Coverage	✅	TCI: 90.0%	"Excellent coverage"
Sensitive Fields	✅	0 fields	"All secured"
Evidence Quality	✅	2 exact · 0 whole-file · 0 coarse	"All 2 citations resolve to exact line spans."

📋 The Verdict

✅ ELEMENTARY - Ship immediately!
"The evidence is conclusive. No mysteries remain."

Signed and sealed,

• S. Holmes, Consulting Detective

[END OF INVESTIGATION FOR COMMIT 5912604]

🧵 Command Run

• Run ID: run-1e9da578-b2df-408b-b611-f3a643ee90a0
• Transmutation: holmes-investigate
• Command: investigate
• Status: completed
• Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

---

🩺 Dr. WATSON full report (click to expand)

🩺 Dr. Watson's Independent Verification Report

Medical Examination of Evidence

• Examination Date: 2026-05-27T02:34:41.409Z
• Patient SHA: 5912604

🔬 Citation Verification

"Let me examine each piece of evidence independently..."

• Citations Examined: 2
• Verified: 0 ✅
• Failed: 0 ❌
• Unable to Verify: 2
• Exact Subrange Citations: 0
• Whole-file Citations: 0
• Coarse Citations: 0
• Evidence Trust: missing
• Trust Note: No evidence citations were available for trust analysis.

Verification Rate: 0.0%

📊 Mathematical Verification

"I shall recalculate Holmes's arithmetic..."

Holmes claimed SCS: 95.0%
Watson calculates: 100.0%
Difference: ⚠️ Significant

🔍 Consistency Analysis

"Checking for contradictions in Holmes's deductions..."

✅ No logical inconsistencies detected

🩺 Dr. Watson's Medical Opinion

VERIFICATION: CONCERNS NOTED ⚠️

"While Holmes's methods are generally sound, I have noted some"
"discrepancies that warrant further investigation. No evidence citations were available for trust analysis."

Respectfully submitted,

• Dr. J. Watson, M.D.
  Medical Examiner & Verification Specialist

🧵 Command Run

• Run ID: run-fd9cc055-5338-43ff-813a-16ac0ab69b98
• Transmutation: watson-verify
• Command: verify
• Status: completed
• Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

---

🔮 Professor MORIARTY full report (click to expand)

🧠 Professor Moriarty's Temporal Predictions

The Mathematics of Inevitability

• Analysis Date: 2026-05-27T02:35:22.062Z

INSUFFICIENT DATA

"I require at least two data points to predict the future."
"Run Wesley generate multiple times to build history."

🧵 Command Run

• Run ID: run-bb3eac06-7936-49f3-81a5-eda6f187a4dd
• Transmutation: moriarty-predict
• Command: predict
• Status: completed
• Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

---

Machine-readable reports: holmes-report.json · watson-report.json · moriarty-report.json (see workflow artifacts).

---

Filed at 221B Repository Street