Conversation
Signed-off-by: Barry Wu <a0987818905@gmail.com>
Signed-off-by: Barry Wu <a0987818905@gmail.com>
Signed-off-by: Barry Wu <a0987818905@gmail.com>
Signed-off-by: Barry Wu <a0987818905@gmail.com>
popojk
left a comment
popojk
left a comment
There was a problem hiding this comment.
Overall looks good, thanks! Left a few comments, PTAL
| s3: | ||
| disableSSL: true | ||
| v2Signing: true | ||
| endpoint: http://rustfs.{{ .Release.Namespace }}:9000 |
There was a problem hiding this comment.
Could we keep using rustfs.{{ .Release.Namespace }} as service name instead of hard coding?
| "helm.sh/hook": post-install,post-upgrade | ||
| "helm.sh/hook-weight": "10" | ||
| "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded | ||
| spec: |
There was a problem hiding this comment.
I noticed that the job pod remain in cluster after job finished. could we add a ttlSecondsAfterFinished under spec section to delete it?
| metadata: | ||
| labels: | ||
| {{- include "flyte-demo.selectorLabels" . | nindent 8 }} | ||
| app.kubernetes.io/component: rustfs-bucket-init |
There was a problem hiding this comment.
Curious why do we need this label here? I thought this is just an one-off k8s job and maybe we don't need label?
| secret: | ||
| rustfs: | ||
| access_key: rustfs | ||
| secret_key: rustfsstorage |
There was a problem hiding this comment.
I noticed that there is a rustfs test connection pod remain in the cluster, which is not required because the sandbox should failed to startup if connection failed. We can do so by:
test:
enabled: false
| kustomize/dev > manifests/dev.yaml | ||
|
|
||
| CONSOLE_IMAGE := ghcr.io/flyteorg/flyte-client-v2 | ||
| CONSOLE_IMAGE := ghcr.io/unionai-oss/flyteconsole-v2 |
There was a problem hiding this comment.
@pingsutw I'm not sure if we will pull console image from ghcr.io/unionai-oss in the future? Should we do this fix here?
There was a problem hiding this comment.
I already changed the image name to ghcr.io/unionai-oss/flyteconsole-v2 in another PR
3 participants
Tracking issue
Closes #7209
Why are the changes needed?
According to rustfs doc, we can run it with helm chart instead of scripting the yaml on our own.
We run an init container to create default bucket now because rustfs do not support default bucket config now. After migrating to helmchart, we can run a k8s post-install Job to create default bucket.
What changes were proposed in this pull request?
Use Helm to init rustfs in sandbox and run k8s post-install Job to create default bucket.
How was this patch tested?
Run make sandbox-build.
Run an example workflow and make sure the result is success.
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main