fix(helm): set catalog-cache to noop when datacatalog is disabled in flyte-core#7234
Open
nuthalapativarun wants to merge 2 commits intoflyteorg:masterfrom
Open
Conversation
EngHabu
approved these changes
Apr 18, 2026
When datacatalog.enabled=false in flyte-core, the catalog-cache config still defaulted to type: datacatalog, causing DNS failures on every task execution since the datacatalog service does not exist. Conditionally render catalog.yaml with type: noop when datacatalog is disabled, preventing connection attempts to a non-existent datacatalog endpoint. Closes flyteorg#7155 Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
nuthalapativarun
force-pushed
the
fix/datacatalog-catalog-cache-mismatch-7155
branch
from
49d3caa to
3dca5c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 56.95% 56.46% -0.49%
==========================================
Files 931 909 -22
Lines 58234 56756 -1478
==========================================
- Hits 33166 32048 -1118
+ Misses 22017 21735 -282
+ Partials 3051 2973 -78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #7155
Why are the changes needed?
When
datacatalog.enabled=falsein the flyte-core Helm chart, thecatalog-cacheconfiguration still defaults totype: datacatalogwithendpoint: datacatalog:89. Since the datacatalog service is not deployed in this case, every task execution triggers a DNS lookup failure:These two related settings are far apart in
values.yaml(datacatalog toggle at line 273, catalog-cache config buried inside configmaps at line 1055), making it easy to miss the dependency.What changes were proposed in this pull request?
In
charts/flyte-core/templates/propeller/configmap.yaml, thecatalog.yamlconfigmap entry is now rendered conditionally:datacatalog.enabled=true(default): renders the existingconfigmap.catalogvalue as before, preserving full backward compatibility.datacatalog.enabled=false: renderscatalog-cache.type: noopso propeller skips catalog lookups entirely, preventing DNS failures.How was this patch tested?
Verified with
helm templatethat:--set datacatalog.enabled=falseproducescatalog-cache:\n type: noop--set datacatalog.enabled=true(default) produces the original datacatalog endpoint config unchangedLabels
fixed
I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.