Fix PydanticTransformer to handle locally-defined nested models #3373
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use model_fields instead of typing.get_type_hints() in get_literal_type to handle Pydantic models with forward references to locally-defined classes. typing.get_type_hints() fails when it cannot resolve forward references that are not in the module's global namespace (e.g., classes defined inside functions). Pydantic's model_fields already has the resolved type information, making it more robust for these cases. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
samhita-alla and
wild-endeavor
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
model_fieldsinstead oftyping.get_type_hints()inget_literal_typeto handle Pydantic models with forward references to locally-defined classestyping.get_type_hints()fails when it cannot resolve forward references that are not in the module's global namespace (e.g., classes defined inside functions)model_fieldsalready has the resolved type information, making it more robust for these casesTest plan
test_pydantic_model_with_locally_defined_nested_modelthat verifies:get_literal_typeworks with locally-defined nested modelsto_literalserializes the model correctlyto_python_valuedeserializes the model correctly with all values preserved