Improve dataclass type guessing to handle nested types #3375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When using
FlyteRemote.execute()with a Pydantic model that contains a list of another Pydantic model (e.g.,jobs: List[JobConfig]), the execution fails with aKeyError: 'type'error.
This occurs because Pydantic generates JSON schemas that use
$refto reference nested model definitions in$defs. For example:The
_get_element_type()function intype_engine.pydid not handle$refreferences, expecting a direct type key instead, which caused theKeyError.What changes were proposed in this pull request?
This PR adds support for
$refresolution in JSON schema processing:referenced definition in $defs (or definitions for older schemas) and recursively converts it to a Python class.
The fix follows a similar pattern to the one implemented in flyte-sdk PR #426.
How was this patch tested?
Added unit tests in tests/flytekit/unit/core/test_dataclass_guessing.py:
Setup process
Screenshots
Check all the applicable boxes
Related PRs
https://github.com/flyteorg/flyte-sdk/pull/426/changes
Docs link