Conversation
AndysWorth
left a comment
AndysWorth
left a comment
There was a problem hiding this comment.
This review was quite painless, thanks!
|
|
||
| # Note the Maintainer | ||
| MAINTAINER Flywheel <support@flywheel.io> | ||
| LABEL MAINTAINER "Flywheel <support@flywheel.io>" |
There was a problem hiding this comment.
Hmmm, this is new to me, so I looked it up. Apparently it should be LABEL maintainer="support@flywheel.io".
See https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
and also https://medium.com/@chamilad/lets-make-your-docker-image-better-than-90-of-existing-ones-8b1e5de950d. Apparently there is a lot more we can add here.
| RUN pip3 install --upgrade pip && \ | ||
| pip3.5 install \ | ||
| flywheel_sdk==8.2.0 \ | ||
| flywheel_sdk==10.7.0 \ |
There was a problem hiding this comment.
10.7.4 happened 3 days ago. I keep this link handy: https://gitlab.com/flywheel-io/product/backend/core/-/tags
| pip3.5 install \ | ||
| flywheel_sdk==8.2.0 \ | ||
| flywheel_sdk==10.7.0 \ | ||
| flywheel_bids \ |
There was a problem hiding this comment.
This one is now 0.8.2 https://gitlab.com/flywheel-io/public/bids-client/-/tags
| flywheel_sdk==10.7.0 \ | ||
| flywheel_bids \ | ||
| flywheel-gear-toolkit \ | ||
| bids-validator \ |
There was a problem hiding this comment.
| bids.run_validation(context) | ||
| try: | ||
| # To download and validate BIDS | ||
| context.download_session_bids(target_dir=context.work_dir/'bids') |
There was a problem hiding this comment.
I switched from using download_session_bids() to download_project_bids() because the project version also downloads "dataset_description.json" and the session version didn't. Has that changed? I guess what I'm asking is, does the validator accept it? I assume it must. I guess I need to look at this again.
2 participants
Updated the Dockerfile to pull Cpac v1.6.0.
Successfully ran under these conditions.
Consider updating with gear-toolkit and methods, when it is available.