Conversation
Php8.4 support
This reverts commit f4d231c.
WalkthroughThe GitHub Actions workflows for building and testing OpenLiteSpeed Docker images have been updated to add PHP 8.4 support. Both the deploy and test workflow matrices now include PHP 8.4, ensuring that images for this version are built and tested alongside existing PHP versions. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Build Matrix
participant Docker Build
participant Test Suite
GitHub Actions->>Build Matrix: Expand matrix (php_version: 7.4, 8.1, 8.2, 8.3, 8.4)
loop For each php_version
Build Matrix->>Docker Build: Build OpenLiteSpeed image with PHP $version
Docker Build->>Test Suite: Run tests on built image
Test Suite-->>GitHub Actions: Report results
end
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/deploy.yml(2 hunks).github/workflows/test.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: build-openlitespeed (8.4, lsphp84)
- GitHub Check: build-openlitespeed (8.3, lsphp83)
- GitHub Check: build-openlitespeed (8.2, lsphp82)
- GitHub Check: build-php (8.4)
- GitHub Check: build-php (8.1)
- GitHub Check: build-openlitespeed (8.1, lsphp81)
- GitHub Check: build-php (7.4)
- GitHub Check: build-openlitespeed (7.4, lsphp74)
- GitHub Check: build-php (8.2)
- GitHub Check: build-php (8.0)
- GitHub Check: build-php (8.3)
🔇 Additional comments (4)
.github/workflows/deploy.yml (3)
84-85: Confirmlsphp84packages exist in LiteSpeed repos
If LiteSpeed hasn’t shippedlsphp84yet, the Dockerfile build will fail onapt-get install lsphp84. Double-check the repo or pin the job behind a feature flag until the package is published.
21-21: Verify upstream availability of thephp:8.4base image before merging
8.4is added to the build matrix, but the official PHP Docker library may not publish that tag yet (or it may still be in alpha). A missing base image will break the whole workflow at build time.#!/usr/bin/env bash # Quick sanity-check: does the official library already expose a `8.4` tag? curl -fsSL "https://registry.hub.docker.com/v2/repositories/library/php/tags/8.4" | jq '.name' || echo "Tag not found"
74-85: ```shell
#!/bin/bash
set -eecho "=== build-php job (including matrix) ==="
rg -n "build-php:" -A10 .github/workflows/deploy.yml || trueecho
echo "=== build-openlitespeed job (including matrix) ==="
rg -n "build-openlitespeed:" -A10 .github/workflows/deploy.yml || trueecho
echo "=== All php_version definitions in .github/workflows/deploy.yml ==="
rg -n "php_version:" .github/workflows/deploy.yml || true</details> <details> <summary>.github/workflows/test.yml (1)</summary> `17-17`: **Same caution as in the deploy workflow: make sure `php:8.4` is actually pull-able** The unit-test workflow will also fail early if the tag is missing. Consider gating the job or using an `allow-failure` strategy until 8.4 GA images land. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
2 participants
Summary by CodeRabbit