Skip to content

formulations#361

Merged
jvoigtlaender merged 6 commits intofmidue:masterfrom
jvoigtlaender:patch-1
May 7, 2026
Merged

formulations#361
jvoigtlaender merged 6 commits intofmidue:masterfrom
jvoigtlaender:patch-1

Conversation

@jvoigtlaender
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 7, 2026 12:40
@jvoigtlaender
Copy link
Copy Markdown
Member Author

subsumes #360

closes #318

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines task text formulations in the semantics resolution exercises to better match the intended meaning and the expected answer format.

Changes:

  • Adjusts English phrasing in Step to align with the German “Lösungsversuch” wording (“solution attempt” instead of “valid solution”).
  • Fixes the Prolog task instructions to refer to the resolvent (not the clauses), consistent with the required (literal, resolvent) tuple output and the shown examples.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/LogicTasks/Semantics/Step.hs Tweaks English instructional text for better semantic alignment with the German phrasing.
src/LogicTasks/Semantics/Prolog.hs Corrects instruction text to reference the resolvent, matching the task’s tuple format and example output.

@jvoigtlaender jvoigtlaender merged commit dd1db46 into fmidue:master May 7, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants