Skip to content

Python Scripts from Zorn and Ronecker SS17#1

Open
B-Zorn wants to merge 7 commits into
fmirus:mainfrom
B-Zorn:master
Open

Python Scripts from Zorn and Ronecker SS17#1
B-Zorn wants to merge 7 commits into
fmirus:mainfrom
B-Zorn:master

Conversation

@B-Zorn

@B-Zorn B-Zorn commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread data_handling/NN_control_node.py Outdated

class Controler:
def __init__(self, image_topic='torcs_ros/pov_image',control_topic='/torcs_ros/ctrl_cmd', sensors_topic='/torcs_ros/sensors_state'):
self.model_path = '/home/max/Schreibtisch/weights_epoch_99.h5' #load neural net at path

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B-Zorn please make the model path a parameter instead of hard coding it here! Will you upload an example of one trained model to the LRZ shared drive or add it to this PR (depending on size of the file)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll upload a trained model to the LRZ drive

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your effort 😃

self.sleep_rate = 0.2 #variable used to limit data to every x seconds
self.extension ="ben" #define user prefix for file name
self.find_dir() #find current working directory
self.evalFactor = 1.5 #factor used for eval

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B-Zorn please make those parameters readable from a yaml-file. An example how to do this can be found in here

@fmirus

fmirus commented Oct 10, 2017

Copy link
Copy Markdown
Owner

@B-Zorn looks good in general. Would it be possible to put the data-logger in a separate ROS-package, as its functionality is kind of separated from the controller and the network training? Furthermore, please have a look at the folder-structure of the other packages in the repository to make the purpose of individual files a bit more self-explanatory. Thanks :)

@B-Zorn

B-Zorn commented Oct 10, 2017

Copy link
Copy Markdown
Contributor Author

@fmirus: I'd argue the data-logger's functionality is very similar as it is identical to basically all other ROS nodes in the package. It subscribes, (synchronizes and saves data) and then republishes said synchronized data if needed.
The network training on the other hand is entirely independent of any ROS function and should therefore probably be kept separate.
Am working on the other changes currently.

@fmirus

fmirus commented Oct 13, 2017

Copy link
Copy Markdown
Owner

@B-Zorn Agree, that the data-logger publishes/subscribes data in a similar way as the other nodes, however the functionality of the node itself is different to what e.g. torcs_ros_drive_ctrl does (logging vs controlling the vehicle). That's why I would like to put it into a separate ROS-package within the same repository. Same holds true, for your DNN-based driver node.

@B-Zorn

B-Zorn commented Nov 12, 2017

Copy link
Copy Markdown
Contributor Author

@fmirus
Requested changes to package structure have been made if I didn't make any mistakes. Sorry for the big delay!
I hope everything is in order now.

fmirus pushed a commit that referenced this pull request Aug 22, 2018
minor fix to avoid watchdog crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants