Implement lock summaries for interprocedural analysis in LockOwnership#55
Open
michael-schwarz wants to merge 7 commits intofocs-lab:tsan-with-ea-IPAfrom
Open
Implement lock summaries for interprocedural analysis in LockOwnership#55michael-schwarz wants to merge 7 commits intofocs-lab:tsan-with-ea-IPAfrom
michael-schwarz wants to merge 7 commits intofocs-lab:tsan-with-ea-IPAfrom
Conversation
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
…-in-lockownership-again Implement lock summaries for interprocedural analysis in LockOwnership
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces full exit state propagation at call sites with precise lock summaries tracking which locks a function may release and which it must acquire.
Changes
Data structures: Extended
FuncStateTywithMayUnlockandMustLocksetsMayUnlock: Locks held at entry but not at exit (released on some path)MustLock: Locks held at exit but not at entry (newly acquired on all paths)Summary computation: In
buildSummary(), compute summaries by comparing entry and exit statesCall edge handling: In
applyTransferFunc(), apply summaries instead of full exit stateMayUnlockfrom current locksetMustLockto current locksetExample
This enables more precise tracking of lock state changes across function boundaries, particularly for functions that partially modify the lockset.
Original prompt
LockOwnership.cppmichael-schwarz/llvm-project#1✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.