UIREQ-1352: Fixed CSV export issue when searching by title#1358
Merged
Dmitriy-Litvinenko merged 1 commit intomasterfrom Mar 9, 2026
Merged
UIREQ-1352: Fixed CSV export issue when searching by title#1358Dmitriy-Litvinenko merged 1 commit intomasterfrom
Dmitriy-Litvinenko merged 1 commit intomasterfrom
Conversation
Dmitriy-Litvinenko
force-pushed
the
UIREQ-1352
branch
from
a0c62c9 to
775a590
Compare
|
zburke
approved these changes
Mar 6, 2026
Member
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
Code LGTM but nowhere in the ticket or the PR body is there any description of what the actual problem is or how this change addresses it. It looks like there are two bugs:
item.titleshould beinstance.title- vastly different search strings used across different routes when they should all be the same
Is that correct? If so, whew, I understood correctly 😄; please update the PR description to confirm this. If not, uhhhh, I guess I have misunderstood 😕; please update the PR description and explain what I missed.
** Ugh, will keeping this module's core code in a directory named deprecated ever be addressed? It was supposed to be a "temporary" fix according to #1224, but it has never been addressed.
OleksandrHladchenko1
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixed CSV export issue when searching by title
Search strings for CSV report obsolete and should be the same as we use for search bar.
Refs
https://folio-org.atlassian.net/browse/UIREQ-1352