Skip to content

WIP: DEV: Including EMMO package#260

Open
flongford wants to merge 4 commits intomasterfrom
dev/inc-emmo
Open

WIP: DEV: Including EMMO package#260
flongford wants to merge 4 commits intomasterfrom
dev/inc-emmo

Conversation

@flongford
Copy link
Copy Markdown
Contributor

@flongford flongford commented Jan 14, 2020

This PR experiments with including the European Materials Modelling Ontology EMMO package in the BDSS.

Considering that the ontology is an instance, rather than a library, we much decide where to contain this object as a reference during run time. Initially we have experimented with allocating it as a attribute of the Workflow, since each DataValue object is expected to have a type attribute corresponding to a ontology class. A method should then be constructed to map each DataValue.type attribute to an existing Ontology.<class> object.

This may be combined with similar methods that have been constructed to identify Variable objects from corresponding DataValue instances.

Change log

  • Dependencies are updated in the CI for EMMO to be installed through pip
  • NOTE: any machine installing force-bdss now MUST have a local installation of JDK. This is currently not checked in the CI
  • New ontology attribute on Workflow class

To Do

  • Construct method to map ontology classes to DataValue types

@flongford flongford added enhancement wip work in progress labels Jan 14, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 14, 2020

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          55       55           
  Lines        1536     1536           
  Branches      148      148           
=======================================
  Hits         1483     1483           
  Misses         49       49           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd2d11...f1cf1b4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement wip work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants