Conversation
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 55 55
Lines 1536 1536
Branches 148 148
=======================================
Hits 1483 1483
Misses 49 49
Partials 4 4Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR experiments with including the European Materials Modelling Ontology EMMO package in the BDSS.
Considering that the ontology is an instance, rather than a library, we much decide where to contain this object as a reference during run time. Initially we have experimented with allocating it as a attribute of the
Workflow, since eachDataValueobject is expected to have atypeattribute corresponding to a ontology class. A method should then be constructed to map eachDataValue.typeattribute to an existingOntology.<class>object.This may be combined with similar methods that have been constructed to identify
Variableobjects from correspondingDataValueinstances.Change log
EMMOto be installed throughpipforce-bdssnow MUST have a local installation of JDK. This is currently not checked in the CIontologyattribute onWorkflowclassTo Do
DataValuetypes