WIP: ENH: Integration of CUDS using osp-core package#281
Open
WIP: ENH: Integration of CUDS using osp-core package#281
Conversation
Contributor
Author
|
This implementation is not ideal, since we end up needing a registry system for In which case, we should redefine the |
Contributor
Author
|
Note: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this PR requires a local installation of
osp-core>=3.3.2Integration with CUDS-type ontologies is achieved using
osp-corepackage. This PR expands upon theCUBATypeattribute functionalities in order to allow for a simple python basic type andTraitTypeclass lookup for a given CUBA key.Consequently, we are now able to utilise powerful extended physical unit typing abilities provided by an ontology. We expect later extensions to expand upon this by integrating external software wrappers built around the
osp-coreontology system.Approaches #279
Change log:
osp-core>=3.3.2(expected to fail on Travis CI)Ontologyclass, a subclass ofTraitType, allowing forHasTraitssubclasses to holdOntologyNamespaceattributesIOntologyRegistryclass providing an interface between loadedosp-coreontologies andCUBATypeobjectsCUBATypeMixinclass providing the ability to look up CUBA keys in a providedIOntologyRegistryCUBATypeclass now contains regex rules determined byosp-coreTypeMCOStartEventthat is able to report variable trait type as well as name information