Skip to content

refactor: unify ResultSet implementations on Arrow-backed path #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkaufmann merged 24 commits into from
May 20, 2026

fix: tighten BaseIntVectorAccessor.getBoolean to spec-strict 0/1 only

96925fd
Select commit
Loading
Failed to load commit list.
Merged

refactor: unify ResultSet implementations on Arrow-backed path #175

fix: tighten BaseIntVectorAccessor.getBoolean to spec-strict 0/1 only
96925fd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 19, 2026 in 0s

80.51% (-1.87%) compared to f47714f

View this Pull Request on Codecov

80.51% (-1.87%) compared to f47714f

Details

Codecov Report

❌ Patch coverage is 75.13514% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.51%. Comparing base (f47714f) to head (96925fd).

Files with missing lines Patch % Lines
...sforce/datacloud/jdbc/core/DataCloudResultSet.java 75.75% 47 Missing and 1 partial ⚠️
...tacloud/jdbc/core/metadata/MetadataResultSets.java 65.45% 15 Missing and 4 partials ⚠️
.../datacloud/jdbc/protocol/data/VectorPopulator.java 76.11% 11 Missing and 5 partials ⚠️
...atacloud/jdbc/protocol/QueryResultArrowStream.java 25.00% 6 Missing ⚠️
...jdbc/core/accessor/impl/BaseIntVectorAccessor.java 66.66% 1 Missing and 1 partial ⚠️
...e/datacloud/jdbc/core/ArrowStreamReaderCursor.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #175      +/-   ##
============================================
- Coverage     82.37%   80.51%   -1.87%     
+ Complexity     1871     1703     -168     
============================================
  Files           125      122       -3     
  Lines          5020     4941      -79     
  Branches        540      520      -20     
============================================
- Hits           4135     3978     -157     
- Misses          642      735      +93     
+ Partials        243      228      -15
Components Coverage Δ
JDBC Core 80.86% <75.13%> (-2.29%) ⬇️
JDBC Main 40.69% <ø> (ø)
JDBC HTTP 90.30% <ø> (ø)
JDBC Utilities 65.25% <ø> (ø)
Spark Datasource ∅ <ø> (∅)
Files with missing lines Coverage Δ
...force/datacloud/jdbc/core/DataCloudConnection.java 57.04% <100.00%> (ø)
...datacloud/jdbc/core/DataCloudDatabaseMetadata.java 98.34% <100.00%> (-0.01%) ⬇️
...sforce/datacloud/jdbc/core/DataCloudStatement.java 80.90% <100.00%> (-0.20%) ⬇️
...alesforce/datacloud/jdbc/core/MetadataSchemas.java 96.87% <100.00%> (+0.04%) ⬆️
...esforce/datacloud/jdbc/core/QueryMetadataUtil.java 95.40% <100.00%> (ø)
...oud/jdbc/core/SQLExceptionQueryResultIterator.java 75.00% <ø> (ø)
...jdbc/core/metadata/DataCloudResultSetMetaData.java 80.48% <100.00%> (-5.56%) ⬇️
...oud/jdbc/protocol/data/ArrowToHyperTypeMapper.java 67.85% <100.00%> (+6.03%) ⬆️
...datacloud/jdbc/protocol/data/HyperTypeToArrow.java 76.74% <100.00%> (-1.52%) ⬇️
.../com/salesforce/datacloud/jdbc/util/Constants.java 0.00% <ø> (ø)
... and 6 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov