feat: add NGT support @W-22143534@#198
Merged
Merged
Conversation
andresrivas-sf
left a comment
andresrivas-sf
left a comment
There was a problem hiding this comment.
It looks good so far! Just a couple of minor questions.
- Guard findIndex -1 result to prevent invalid Position(-1, 8) - Replace TestStatus | string with TestStatus | AgentforceStudioTestStatusResponse['status'] in polling event type - Use !test.parentName instead of == '' for consistency - Add comment explaining why empty testScorerResults counts as failure
- Handle CREATED and FAILED AgentforceStudio statuses in polling event listener to prevent progress notification hanging indefinitely - Fix hasFailure accumulation bug in runTestingCenterTest (was overwriting on each iteration instead of accumulating) - Guard against missing testCase element in XML parsing - Replace map() with forEach() for all side-effect-only loops - Eliminate double-filter in printTestSummary and printAgentforceStudioTestSummary (use total - passing) - Eliminate double parse of scorer responses in displayAgentforceStudioTestCases (accumulate during render loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds NGT support to VSC
What issues does this PR fix or reference?
requires: forcedotcom/agents#272
#, @W-22143534@
Functionality Before
no NGT suppoprt
Functionality After
ATD / NGT tests in testing panel
Testing Setup Notes