fix: clarify empty-state message in Activate Agent picker @W-22497097@#209
Merged
Merged
Conversation
…497097@ The "Activate Agent" command palette picker said "No deactivated agents found in the org." even when freshly published agents (with only an Inactive v1, never previously Active) were eligible to activate. The filter logic was correct; only the message wording was misleading. Replace with two accurate branches: "No published agents found in the org." (no agents) and "No published agents are available to activate." (all already have an active version). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
marcelinollano
changed the title
npiccolo
approved these changes
May 15, 2026
Contributor
npiccolo
left a comment
npiccolo
left a comment
There was a problem hiding this comment.
Review ✅
Minimal, correct fix. The filter logic was already right — only the empty-state copy needed updating. Two accurate messages now cover the two distinct cases: no agents at all vs. all agents already active.
npm run test:backend — 386/386 ✅
npm run test:frontend — 434/434 ✅
LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@W-22497097@
The Command Palette "SFDX: Activate Agent" picker reported "No deactivated agents found in the org." even when freshly published agents (with only an Inactive v1, never previously Active) were eligible to activate. The filter logic was already correct (an agent is activatable when it has no version with
Status === 'Active', matching@salesforce/plugin-agentsrc/agentActivation.ts:52-70); only the empty-state message wording was misleading.Before
Picker shows "No deactivated agents found in the org." regardless of why no agents are eligible — even when fresh-publish Inactive agents should appear, and when all agents are simply already active.
After
Two accurate messages:
(The picker itself was always correctly listing fresh-publish Inactive agents; the broken piece was the wording shown when nothing matched.)
Testing
Automated
Expected: 14 passed. Covers the new "no agents in org" and "all already active" branches plus the existing fresh-publish/Inactive picker behavior.
Manual
SFDX: Activate Agent. Expected: the agent appears in the picker; selecting it lets you choose a version and activates it.SFDX: Activate Agent. Expected: info toastNo published agents are available to activate.SFDX: Activate Agent. Expected: info toastNo published agents found in the org.