fix: replace UseAdvancedExtensions with selective pipeline to fix phantom table columns (#68)#69
Merged
Conversation
…ntom table columns (#68) Markdig's subscript extension (~) causes misparse of table cell boundaries when tilde appears inside bold markers (e.g., **~$1.50**), creating extra phantom columns. Replace UseAdvancedExtensions() with explicit extension registration, enabling only strikethrough (~~) via EmphasisExtraOptions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 88.54% 88.69% +0.15%
==========================================
Files 27 27
Lines 1405 1424 +19
Branches 179 179
==========================================
+ Hits 1244 1263 +19
Misses 122 122
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**) combined with tilde (~) inside table cells caused Markdig to create phantom columnsUseAdvancedExtensions()enables the subscript extension where~is a delimiter. When**~$1.50**appears in a table cell, the subscript parser interferes with cell boundary detection, inflating column countUseAdvancedExtensions()with explicit extension registration, usingUseEmphasisExtras(EmphasisExtraOptions.Strikethrough)to keep~~strikethrough~~support while disabling subscript (~) and superscript (^)Test plan
~~strikethrough~~still works in tables~preserved in cell text