Skip to content

feat: support lists inside blockquotes#71

Merged
forest6511 merged 1 commit into
mainfrom
feature/blockquote-list-support
Mar 16, 2026
Merged

feat: support lists inside blockquotes#71
forest6511 merged 1 commit into
mainfrom
feature/blockquote-list-support

Conversation

@forest6511
Copy link
Copy Markdown
Owner

Summary

  • Adds structured QuoteContent model with QuoteParagraph and QuoteList block types, following the same polymorphic pattern as FencedDivContent
  • Refactors Helpers.GetQuoteRuns()GetQuoteContent() to extract both paragraphs and lists from blockquotes
  • Each list item renders as a separate paragraph with full quote styling (border, background, indentation)

Closes #70

Changes

File Change
QuoteContent.cs New model: QuoteContent, QuoteContentBlock, QuoteParagraph, QuoteList
Helpers.cs GetQuoteRunsGetQuoteContent with ListBlock switch case
IDocumentBuilder.cs AddQuote(IReadOnlyList<InlineRun>, ...)AddQuote(QuoteContent, ...)
OpenXmlDocumentBuilder.cs New AddQuoteParagraph + AddQuoteList private methods
Program.cs Updated dispatch to use GetQuoteContent

Test plan

  • 309 tests passing (302 existing + 7 new)
  • New parser tests: list inside quote, paragraph+list, ordered list, plain text (regression)
  • New builder tests: unordered list, ordered list, mixed content, empty content
  • All existing quote tests updated and passing (null checks, padding, borders, bold/code runs)

Replace flat InlineRun-based quote extraction with structured QuoteContent
model (QuoteParagraph + QuoteList), following the same polymorphic pattern
used by FencedDivContent. Each list item renders as a separate paragraph
with full quote styling (border, background, indentation).

- Add QuoteContent/QuoteContentBlock/QuoteParagraph/QuoteList models
- Refactor Helpers.GetQuoteRuns → GetQuoteContent with ListBlock handling
- Update IDocumentBuilder.AddQuote signature to accept QuoteContent
- Add AddQuoteParagraph/AddQuoteList private render methods
- Add 7 new tests (309 total, all passing)
@forest6511 forest6511 merged commit 5e01f01 into main Mar 16, 2026
1 check passed
@forest6511 forest6511 deleted the feature/blockquote-list-support branch March 16, 2026 07:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.88%. Comparing base (ba18498) to head (52d821d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   88.69%   88.88%   +0.19%     
==========================================
  Files          27       28       +1     
  Lines        1424     1449      +25     
  Branches      179      183       +4     
==========================================
+ Hits         1263     1288      +25     
  Misses        122      122              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blockquote内のリスト項目が消失する(> - item)

1 participant