Conversation
There was a problem hiding this comment.
Pull request overview
Updates Decimo’s Mojo sources and Pixi environment configuration to track Mojo nightly, adapting code to recent language/stdlib API changes (borrowing qualifiers, unsafe memory routines, and Span API updates).
Changes:
- Retarget Pixi workspace to Mojo nightly (channel + dependency changes) and refresh lockfile.
- Update core numeric types/algorithms to new Mojo borrowing qualifiers (
imm) and stdlib memory APIs (unsafe_memcpy,unsafe_memset_zero, pointer offset access). - Minor TOML/CLI adjustments to align with nightly semantics (e.g., explicit
.copy()in TOML getters, in-place string resize in CLI IO).
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/decimo/toml/parser.mojo | Updates TOML value container typing (Self), lifecycle traits, and returns copies from getters under new ownership rules. |
| src/decimo/str.mojo | Adjusts closure capture qualifiers from read to imm for nightly borrowing rules. |
| src/decimo/decimal128/special.mojo | Adds explicit Decimal128 import for nightly name/type resolution. |
| src/decimo/decimal128/exponential.mojo | Adds explicit Decimal128 import for nightly name/type resolution. |
| src/decimo/decimal128/decimal128.mojo | Updates Span import and field names (unsafe_ptr) to match nightly stdlib changes. |
| src/decimo/biguint/exponential.mojo | Switches to unsafe_memset_zero per nightly stdlib API. |
| src/decimo/biguint/biguint.mojo | Switches to unsafe_memcpy/unsafe_offset and updates local bindings per nightly syntax. |
| src/decimo/biguint/arithmetics.mojo | Broad imm migration + memory API updates; resize API changes (length/fill). |
| src/decimo/bigint10/bigint10.mojo | Updates ref binding syntax for nightly parsing rules. |
| src/decimo/bigint/bitwise.mojo | Replaces read with imm for in-place bitwise helpers. |
| src/decimo/bigint/bigint.mojo | Updates memcpy usage and pointer indexing to nightly pointer/offset conventions. |
| src/decimo/bigint/arithmetics.mojo | Updates memory calls and borrowing qualifiers to nightly conventions. |
| src/decimo/bigdecimal/trigonometric.mojo | Adds explicit BigUInt import needed under nightly. |
| src/decimo/bigdecimal/rounding.mojo | Adds explicit BigUInt import needed under nightly. |
| src/decimo/bigdecimal/exponential.mojo | Reorders/imports BigUInt and updates ref binding syntax for nightly. |
| src/decimo/bigdecimal/constants.mojo | Adds explicit BigUInt import needed under nightly. |
| src/decimo/bigdecimal/bigdecimal.mojo | Adds explicit BigUInt import and updates ref binding syntax for nightly. |
| src/decimo/bigdecimal/arithmetics.mojo | Adds explicit BigUInt/BigDecimal imports needed under nightly. |
| src/cli/calculator/io.mojo | Replaces substring rebuild with in-place String.resize when stripping trailing \r. |
| pixi.toml | Adds nightly channel; loosens mojo constraint; comments out argmojo dependency. |
| pixi.lock | Lockfile refresh reflecting nightly channel and updated package set. |
| benches/bigint/mojo/bench.mojo | Updates bench signatures/comments from read to imm. |
| benches/bigdecimal/mojo/bench.mojo | Updates bench signatures/comments from read to imm. |
Comments suppressed due to low confidence (2)
src/decimo/biguint/arithmetics.mojo:2759
- Typo in comment: "imm" is a borrowing keyword, but here the sentence is about reading from the source list; this should say "read".
# written before src[i+1] is imm.
src/decimo/biguint/arithmetics.mojo:2884
- Typo in comment: "imm" is a borrowing keyword, but this sentence is describing that the source element is read after the destination write; it should say "read".
# before src[i+1] is imm.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+13
| # argmojo = ">=0.7,<0.8" # CLI argument parsing for the Decimo calculator | ||
| mojo = "*" # Mojo language compiler and runtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.