Skip to content

Align package name with directory structure for serialization package#2

Draft
Copilot wants to merge 2 commits intofeat/foundation-packagefrom
copilot/sub-pr-1
Draft

Align package name with directory structure for serialization package#2
Copilot wants to merge 2 commits intofeat/foundation-packagefrom
copilot/sub-pr-1

Conversation

Copy link

Copilot AI commented Feb 9, 2026

The package was declared as foundation despite residing in pkg/forging/foundation/serialization/, causing import confusion where consumers import from a .../serialization path but reference foundation.* identifiers.

Changes

  • Renamed package declaration from foundation to serialization in:
    • json_serializable.go
    • json_serializable_test.go
    • serializable.go

Imports now align with package references:

import "github.com/forging-blocks-org/forging/pkg/forging/foundation/serialization"

// Now use serialization.JSONSerializable instead of foundation.JSONSerializable
obj := &serialization.JSONSerializable{Value: data}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ructure

Co-authored-by: gbrennon <2373929+gbrennon@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP to address feedback on foundation/serialization implementation Align package name with directory structure for serialization package Feb 9, 2026
Copilot AI requested a review from gbrennon February 9, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants