-
Notifications
You must be signed in to change notification settings - Fork 0
fix: unit test isolation, CI feedback, and config priority #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
eeb62bc
feat: add PR workflow, --skip-lint flags, and ShellCheck compliance
forkni 2d8c4f2
chore: add internal dev files to .gitignore
forkni a6bda3b
test: add bats-core testing pipeline for all CGW scripts
forkni 79b8a94
fix: escape pipe chars in sed replacement for hook pattern generation
forkni 25c510e
fix: address Charlie CI feedback — lint flow, blocking, shellcheck co…
forkni 710c442
fix: correct 5 unit test failures — grep double-output, bats stderr c…
forkni 1ee06da
fix: env vars now take priority over .cgw.conf (save/restore pattern)
forkni 1477381
fix: address 9 Charlie CI PR #2 review issues
forkni d1262b8
test: fix all integration test failures (92/92 passing)
forkni b7a525a
fix: address Charlie CI round-2 review — harden config loader, add fe…
forkni d044fdf
fix: address Charlie CI round-3 — config regexes, fetch warning, R1 m…
forkni b232bdf
fix: CGW_LINT_CMD empty-string disable, revert hide_gh to safe shim
forkni 0af3b42
fix: decouple format from lint in commit_enhanced, self-contained con…
forkni 44b7d1c
style: apply shfmt formatting across all scripts
forkni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| logs/ | ||
| *.log | ||
| .cgw.conf | ||
| CLAUDE.md | ||
| SESSION_LOG.md | ||
| .claude/commands/ | ||
| .claude/skills/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # shellcheck configuration — matches CI invocation in branch-protection.yml | ||
| # Enables source-following (-x) and sets source path so local runs | ||
| # produce the same results as: shellcheck -x --source-path=scripts/git | ||
| external-sources=true | ||
| source-path=scripts/git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow installs bats via
git clone --depth 1from default branches. That’s brittle (upstream changes can break CI unexpectedly) and increases supply-chain risk compared to pinning versions.This is especially relevant since branch protection will depend on these checks.
Suggestion
Pin bats-core/bats-support/bats-assert to tags or commit SHAs, or switch to a maintained action (e.g.
bats-core/bats-action) with version pinning.Reply with "@CharlieHelps yes please" if you want me to add a commit that pins these dependencies (either via tags/SHAs or an action).