fix: enhance CORS handling to prevent DNS rebinding and reject prefli…#74
Open
schecthellraiser606 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the HTTP server’s browser-facing surface by removing permissive CORS behavior and explicitly rejecting browser-originated requests, aligning the server with an intended “local MCP bridge only” access model and mitigating DNS rebinding risks.
Changes:
- Removed
Access-Control-Allow-Origin: *from default responses. - Added Origin-header enforcement that rejects requests carrying an
Originheader with HTTP 403. - Added an explicit
OPTIONShandler that rejects CORS preflight requests with HTTP 403.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
@fosdickio
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstruct
No CORS headers: this server is accessed only by local MCP bridge
processes (not browsers). Omitting Access-Control-Allow-Origin
prevents malicious websites from making cross-origin requests.
Validate Origin header per MCP spec to prevent DNS rebinding.
_check_originPer the MCP specification (Streamable HTTP - Security Warning):
servers MUST validate the Origin header on all incoming connections.
If the Origin header is present and invalid, servers MUST respond
with HTTP 403 Forbidden.
This server is only accessed by local MCP bridge processes which
do not send an Origin header. Any request carrying an Origin
header is from a browser and must be rejected.
Reject CORS preflight requests.
do_OPTIONSThis server is accessed only by local MCP bridge processes, never
from a browser. Returning 403 ensures that any browser-initiated
preflight fails and the actual request is blocked.