Adds schemars support and forwards dependency features conditionally#45
Adds schemars support and forwards dependency features conditionally#45StefanTerdell wants to merge 3 commits intofosskers:masterfrom
Conversation
|
@fosskers Sorry about tagging, but not sure how notifications work on GH myself TBH :) Any thoughts on this? |
|
3 weeks of silence from me definitely warrants a ping, yes. Since this is feature-gated it's basically fine, but my main concern is whether |
|
Well, it's been around for about a decade and is the basis of most Open Api generator libs I've used so far. It's also getting 15m monthly downloads, if that means anything :) |
1b76a70 to
8c5d7da
Compare
|
I made a similar pull request for IpNet that was just merged and released: krisprice/ipnet#67. IpNet is used by sqlx among others, so I hope this helps make the case for the wide(ning) adoption of schemars throughout stable crates in the ecosystem :) I am using my fork as a git dependency for now so there's really no rush on my end, just mentioning it to provide some more context. |
|
|
This PR adds optional support for
schemarsthrough a feature flag. It also makes use of the optional dependency feature pattern to forward activation of theserdefeature to - andschemars-related features for -eitherandindexmapwhen those are active as well.Hope you like it :)