Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping to use this crate in a no_std package, but the references to
stdcause compilation failure. Since some structures, such asNESliceandNEVec, don't rely onstddirectly, only things re-expored fromallocorcore, only a minor refactor of imports and some feature guards are necessary for this crate to be usable in embedded environments.I tested these changes locally in another crate, and compiled against a target which has no
stdsupport (thumbv6m-none-eabi), unit tests seem to pass, so hopefully it all works! (Apologies in advance for the slight added maintenance burden of needing to import againstcoreandallocinstead ofstd😅)I also added CI tests to check that this continually builds in
no_stdand non-allocenvironments. (Both against the same target, since I'm not yet sure of a built-in target wherecoreexists but notalloc.)