Conversation
Angles now calculated with start_time, should use scanline time.
Pull Request Test Coverage Report for Build 19759931558Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
We should add the CPP coefficients from KNMI to this branch/installation |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 76.45% 68.62% -7.83%
==========================================
Files 23 25 +2
Lines 1805 2008 +203
Branches 165 191 +26
==========================================
- Hits 1380 1378 -2
- Misses 380 585 +205
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also alow to go directly to msg grid if we have enough RAM.
Undo and commit correct file
BengtRydberg
left a comment
BengtRydberg
left a comment
There was a problem hiding this comment.
Looks good. I added some minor suggetsions for improvement.
| 'units': 'milliseconds since 1970-01-01', | ||
| 'complevel': 4, | ||
| '_FillValue': -1.0} | ||
| elif name in ['ir_105_time']: |
There was a problem hiding this comment.
| elif name in ['ir_105_time']: | |
| elif name == 'ir_105_time': |
| lons, lats, 0) | ||
| satz = 90 - satel | ||
|
|
||
| if lons.shape[0] < 5000: |
There was a problem hiding this comment.
5000 looks like a magic number. Maybe enough we define a variable CHUNK_SIZE = 2000 in top of module and check if size is smaller than this we do this. Alternatively remove this part of the code and always use the "chunking metod".
| """Test setting of attributes.""" | ||
| scene = get_fake_scene() | ||
| fci2pps.set_header_and_band_attrs(scene) | ||
| self.assertEqual(scene["vis_06"].attrs["description"], "FCI VIS_06") |
There was a problem hiding this comment.
Is it possible to assert the complete attrs dict. Or is this big?
There was a problem hiding this comment.
As a compromise I added a few more important attributes
4 participants
Add FCI
pytest level1c4ppsflake8