fix(#469): adjusted sign-up and sign-in prompt alignment#469
Open
emmadal wants to merge 1 commit into
Open
Conversation
|
@emmadal is attempting to deploy a commit to the React Native Reusables Team on Vercel. A member of the Team first needs to authorize it. |
emmadal
changed the title
|
Actually just had this issue too lol |
mrzachnugent
requested changes
Jan 17, 2026
mrzachnugent
left a comment
mrzachnugent
left a comment
Member
There was a problem hiding this comment.
@emmadal Thanks for contributing! Left a few tiny requests.
Comment on lines
-83
to
+86
| <Text className="text-sm underline underline-offset-4">Sign up</Text> | ||
| }} | ||
| > | ||
| <Text className="text-sm underline">Sign up</Text> |
Member
There was a problem hiding this comment.
It looks like underline-offset-4 was removed. Maybe it's because it doesn't do anything on mobile but its for the web platform. Could you please add it back? You can add the prefix web: to make it clearer.
| onPress={() => { | ||
| // TODO: Navigate to sign in screen | ||
| }}> | ||
| <Text className="text-sm underline underline-offset-4">Sign in</Text> |
Member
There was a problem hiding this comment.
If you add the web: prefix for underline-offset-4 in the sign-in-form, could you also add it here please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixed the alignment issue of the "Don't have an account? Sign up" text on
<SignInForm />component and "Already have an account? Sign In"<SignUpForm />componentTested Platforms:
Affected Apps/Packages: