Detect metro.config.cjs for esm projects#519
Open
adambrgmn wants to merge 1 commit into
Open
Conversation
|
@adambrgmn is attempting to deploy a commit to the React Native Reusables Team on Vercel. A member of the Team first needs to authorize it. |
adambrgmn
force-pushed
the
adambrgmn/metro-config-cjs
branch
from
bf66f47 to
464430d
Compare
mrzachnugent
approved these changes
Mar 14, 2026
mrzachnugent
left a comment
mrzachnugent
left a comment
Member
There was a problem hiding this comment.
@adambrgmn Thanks for contributing!
mrzachnugent
requested changes
Mar 14, 2026
mrzachnugent
left a comment
mrzachnugent
left a comment
Member
There was a problem hiding this comment.
Could you please fix the merge conflicts?
adambrgmn
force-pushed
the
adambrgmn/metro-config-cjs
branch
from
464430d to
b7cdbdc
Compare
adambrgmn
force-pushed
the
adambrgmn/metro-config-cjs
branch
from
b7cdbdc to
3ade906
Compare
Author
@mrzachnugent done 👍 sorry for the delay, was caught up in work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description:
This PR adds another file to check if a project uses uniwind instead of nativewind. If this gets merged the cli will also check for
metro.config.cjs, a file-format that is required for projects being setup as native esm projects.This is a very minor feature and I hope it is okey that I opened a PR before initiating a discussion! And huge thanks for the project, it is really helping me and my team.
Tested Platforms:
Affected Apps/Packages:
Screenshots:
Notes:
Some lines were automatically formatted by prettier in my ide. Let me know if you want me to revert them. The interesting changes are on line 71.