fix(separator): use border instead of background for web#527
Open
ekkoitac wants to merge 1 commit into
Open
Conversation
Separator renders as <hr> on web, which doesn't support background-color. Use border-* utilities instead, which correctly style <hr> elements. Fixes founded-labs#525
|
@ekkoitac is attempting to deploy a commit to the React Native Reusables Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separator renders as
<hr>on web, which doesn't supportbackground-color. This fix usesborder-*utilities instead, which correctly style<hr>elements.Changes
Platform.select()to differentiate web from native renderingborder-t border-border(horizontal) /border-l border-border(vertical)bg-borderwith dimensionsFixes #525
Tested Platforms
Affected Apps/Packages
Notes
SeparatorPrimitive.Rootrenders as<hr>on web, where Tailwind'sbg-border(background-color) has no effect. The web platform requiresborder-*utilities to show the line.<View>rendering is unaffected and continues to usebg-border.