Skip to content

Fix dialog overlay press on mobile web#541

Open
badabadabing wants to merge 1 commit into
founded-labs:mainfrom
badabadabing:badabadabing/fix-dialog-overlay-mobile-web
Open

Fix dialog overlay press on mobile web#541
badabadabing wants to merge 1 commit into
founded-labs:mainfrom
badabadabing:badabadabing/fix-dialog-overlay-mobile-web

Conversation

@badabadabing

Copy link
Copy Markdown

Summary

  • close Dialog when the web overlay background itself is pressed
  • preserve custom overlay onPress handlers
  • update nativewind and uniwind registry output for Dialog

Verification

  • pnpm exec prettier --check packages/registry/src/nativewind/components/ui/dialog.tsx packages/registry/src/uniwind/components/ui/dialog.tsx apps/docs/public/r/nativewind/dialog.json apps/docs/public/r/uniwind/dialog.json
  • pnpm exec tsc -p packages/registry/tsconfig.json --noEmit --types react,react-native --moduleResolution bundler --module ESNext
  • pnpm --filter @rnr/showcase build:web
  • Playwright smoke test at 430x932: opened /components/dialog, opened Dialog, clicked overlay background, verified dialog count became 0

Closes #338

@vercel

vercel Bot commented Jun 3, 2026

Copy link
Copy Markdown

@badabadabing is attempting to deploy a commit to the React Native Reusables Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ BUG ] Clicking outside the Dialog modal on mobile web doesn't close dialog

1 participant