feat(cast): wrap cast wallet --json outputs in JsonEnvelope#14922
Draft
mablr wants to merge 4 commits into
Draft
feat(cast): wrap cast wallet --json outputs in JsonEnvelope#14922mablr wants to merge 4 commits into
cast wallet --json outputs in JsonEnvelope#14922mablr wants to merge 4 commits into
Conversation
Completes the --json envelope coverage for `cast wallet`:
- `new` / `new-mnemonic` / `derive` → `print_json_success` (array
payloads)
- `address` / `public-key` / `private-key` (terse) / `sign-auth` (terse)
/ `sign` (terse) → `print_scalar`
- `sign` (verbose) / `sign-auth` (verbose) / `private-key` (verbose) →
`print_json_object`
- `verify` → `{address, result: true}` envelope on success
- `import` / `remove` / `change-password` → `{account, address/removed}`
envelope
- `decrypt-keystore` → `{account, private_key}` envelope
- `vanity` → `{address, private_key, contract_address}` envelope
- `wallet list` → array of `{address, source}` objects
mablr
force-pushed
the
mablr/cast-json-envelope-parity
branch
from
959137a to
60cfa08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #14918
Last stage to close OSS-239.
Completes the --json envelope coverage for
cast wallet:new/new-mnemonic/derive→print_json_success(array payloads)address/public-key/private-key(terse) /sign-auth(terse) /sign(terse) →print_scalarsign(verbose) /sign-auth(verbose) /private-key(verbose) →print_json_objectverify→{address, result: true}envelope on successimport/remove/change-password→{account, address/removed}envelopedecrypt-keystore→{account, private_key}envelopevanity→{address, private_key, contract_address}envelopewallet list→ array of{address, source}objects