Concrete syntax for handler types#337
Open
JakubZojdzik wants to merge 3 commits intofram-lang:masterfrom
Open
Conversation
JakubZojdzik
commented
Apr 12, 2026
| let (in_env, _) = Env.enter_scope env in | ||
| let (in_env, eff_var) = Env.add_tvar ~pos in_env effct T.Kind.k_effect in | ||
| let (in_env, eff_var) = | ||
| if String.equal effct "_" then |
Contributor
Author
There was a problem hiding this comment.
Couldn't think of anything more elegant as effct is expected to be string everywhere
Member
There was a problem hiding this comment.
Generally, it is good practice to avoid if-expressions, where the problem can be solved by pattern-matching. It would be better to change the definition of THandler constructor and have effct field of the option type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#286