ci: add Ubuntu 26.04 to CI + minor flags#238
Conversation
|
Thanks @r-simonelli, did you manage to test it? any performance issues or compilation? |
| && ln -s $(which clang-format-18) /usr/bin/clang-format | ||
| apt-get install -y clang-format-${LLVM_VER} clang-tidy-${LLVM_VER} && \ | ||
| ln -s $(which clang-tidy-${LLVM_VER}) /usr/bin/clang-tidy && \ | ||
| ln -s $(which clang-format-${LLVM_VER}) /usr/bin/clang-format |
There was a problem hiding this comment.
Is llvm 22 working with our code base without throwing errors?
There was a problem hiding this comment.
Hi @AndreasKuhner, thanks for pointing it out. Are you able to visualize the workflows?
The workflows appear to run successfully. Is this enough as a guarantee? Or are you thinking of runtime problems?
The pywheels failure is due to token problems related to publishing:
There was a problem hiding this comment.
E.g. a newer version for clang-tidy usually comes with additional checks etc. which might make the build broke. But I think the workflows should be verifying that... :)
Thanks for answering. For the compilation I am relying on the fact that the workflows run without errors. For the functionality/ performance side, I must admit I am planning to start the library with the newest version so I have no baseline to start with. What I can do is go through the readme examples and verify functionalities. Edit 09/06: the library can be built correctly and I could run some of the examples without issues. For a more complete assessment of the functionality I am afraid I would need to use the library more extensively and possibly open issues as problems arise. I did not look at previous versions as the codebase has not been changed |
resolve conflict from upodating broken links
|
Hi! wanted to bump this. Is there something which needs to be addressed still @francando @AndreasKuhner ? Thanks for dealing with it :) |
| .. _installation-debian-package: | ||
|
|
||
| 2. Installation from Debian Package (Recommended) | ||
| 1. Installation from Debian Package (Recommended) |
|
|
||
| - add_library(${add_urdfdom_library_LIBNAME} SHARED | ||
| + add_library(${add_urdfdom_library_LIBNAME} STATIC |
There was a problem hiding this comment.
this was a "patch on the patch" from my side because I saw the BUILD_SHARED_LIBS_OFF would be overriden by the SHARED keyword. I am not sure whether there may be consequences I am not aware of @AndreasKuhner @francando
There was a problem hiding this comment.
Probably fine? Can be verified by checking the generated .so and check if some urdfdom shows up
3 participants
I added ubuntu 26.04 as the latest paltform to
docker-image.ymllibfranka-build.ymlpylibfranka-wheels.ymlI also made minor modifications to the
urdfpatch, and in theDockerfileto dependencies and command flags