Enhanced routing for CVE and business value management with deeplinks - #655
Merged
Conversation
Closed
Matthbo
requested changes
Jul 8, 2026
Matthbo
requested changes
Jul 20, 2026
| this.selectedBusinessValue.set(null); | ||
| this.resetIssueSelection(); | ||
| this.location.go(`/release-manage/${this.releaseId()}/business-values`); | ||
| this.router.navigate([`/release-manage/${this.releaseId()}/business-values`]); |
Member
There was a problem hiding this comment.
Suggested change
| this.router.navigate([`/release-manage/${this.releaseId()}/business-values`]); | |
| this.router.navigate(['/release-manage', this.releaseId(), 'business-values']); |
https://angular.dev/api/router/Router#navigate
Also for the other router.navigate calls
Contributor
Author
There was a problem hiding this comment.
When i apply this at all places i have duplicate linting errors.
So i used constants for this.
Member
There was a problem hiding this comment.
duplicate linting has to do with recreating the same strings, just saving then as a readonly variable or as a constant in the file should be fine for that
The example I give is more preferred than just duping a single string into the route path array
…gement for improved navigation
Matthbo
reviewed
Jul 20, 2026
Matthbo
left a comment
Matthbo
left a comment
Member
There was a problem hiding this comment.
I replied to the conversation
… improved routing
|
Matthbo
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done for cve-overview, vulnerability-manage and business-value pages