Feature/data updates#49
Merged
Merged
Conversation
Refactored the Program class by moving the using directive for CountryData.Standard to the top, removing the namespace declaration, and adding a summary comment. Changed the Program class to a top-level static class and moved the CountryHelper instance to the top as private static readonly. Refactored the Main method and various other methods to demonstrate the use of the CountryData library. Added a new method GetAllCurrencyCodesByCountryCode. Reformatted the Currency class in Currency.cs and corrected the indentation. Updated data.json to replace empty currency codes and names with "null", added new entries for "Antarctica" and "Antigua and Barbuda", and corrected the formatting for consistency.
Country name updates (ISO 3166-1): - Swaziland -> Eswatini (2018) - Macedonia, Republic of -> North Macedonia (2019) - Turkey -> Türkiye (2022) - Czech Republic -> Czechia - Cape Verde -> Cabo Verde Currency fixes (ISO 4217): - North Korea (KP): Added KPW currency code - Venezuela (VE): VEF -> VES (Bolívar Soberano, 2018) - Tokelau (TK): Added NZD currency code - U.S. Virgin Islands (VI): Added USD currency - Heard Island (HM): Added AUD currency
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update country data to ISO 3166-1 and ISO 4217 standards, including country name changes (Swaziland → Eswatini, Macedonia → North Macedonia, Turkey → Türkiye, etc.) and currency code updates. However, the changes contain numerous critical data corruption issues that prevent the JSON from being valid.
Changes:
- Country name updates for compliance with ISO 3166-1 standards
- Currency code additions and updates for ISO 4217 compliance
- Code formatting changes in Currency.cs and Program.cs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 18 comments.
| File | Description |
|---|---|
| src/CountryData.Standard/data.json | Attempted country and currency data updates, but contains severe JSON corruption throughout |
| src/CountryData.Standard/Currency.cs | Minor whitespace formatting adjustments |
| sample/CountryData.Sample.Console/Program.cs | Code restructuring and addition of new method with typo |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 tasks
Contributor
|
@frankodoom I've opened a new pull request, #50, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@frankodoom I've opened a new pull request, #51, to work on those changes. Once the pull request is ready, I'll request review from you. |
…esByCountryCode Co-authored-by: frankodoom <10815235+frankodoom@users.noreply.github.com>
[WIP] Update country and currency data to ISO standards
[WIP] Update data updates based on feedback in original PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update country data to ISO 3166-1 and ISO 4217 standards
Country name updates (ISO 3166-1):
Currency fixes (ISO 4217):
ow committed to the feature/data-updates branch. Would you like me to push this branch to the remote?