fix(easy-install): support Traefik v3 SITES_RULE and add safe site mismatch handling#1701
Merged
barredterra merged 8 commits intoJul 1, 2026
Conversation
|
Confidence Score: 5/5This looks safe to merge.
Reviews (5): Last reviewed commit: "fix: prevent empty SITES_RULE writes" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
|
@Rocket-Quack can you evaluate Greptile's suggestions and let me know when the PR is ready to merge. |
revant
reviewed
Jun 30, 2026
revant
left a comment
revant
left a comment
Collaborator
There was a problem hiding this comment.
Pass the automated tests and review.
Lgtm.
barredterra
approved these changes
Jun 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1696
Fixed because frappe-docker now accepts a different format for site_rules due to traefik updates.
Summary
This PR updates
easy-install.pyfor Traefik v3-compatible site routing and adds safer handling when--sitenamediffers from an existing project .envChanges
--confirm-site-mismatchoption for build, deploy, and upgrade--sitename:README.mdfor new flag and migration behavior