Skip to content

feat: Increment/Decremet arrow keys#547

Open
Vibhuti410 wants to merge 8 commits intofrappe:developfrom
Vibhuti410:arrow-keys
Open

feat: Increment/Decremet arrow keys#547
Vibhuti410 wants to merge 8 commits intofrappe:developfrom
Vibhuti410:arrow-keys

Conversation

@Vibhuti410
Copy link
Copy Markdown
Collaborator

@Vibhuti410 Vibhuti410 commented Apr 12, 2026

Added arrows keys to increment/decrement the numeric input on hover.

Demo:

feat.mov

Closes #546

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.93%. Comparing base (1d53a38) to head (3fe3cd2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #547   +/-   ##
========================================
  Coverage    57.93%   57.93%           
========================================
  Files           28       28           
  Lines         3105     3105           
========================================
  Hits          1799     1799           
  Misses        1306     1306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

surajshetty3416

This comment was marked as duplicate.

Copy link
Copy Markdown
Member

@surajshetty3416 surajshetty3416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vibhuti410

  • The gap between arrows should be less so that it has some space around the edges (we already discussed this)
  • For few inputs, arrow keys does not make sense or the step should be different... example, in font weight it can be incremented/decremented by 100 instead of 1... it should also have min and max constraints. Please go through all such inputs
    Screenshot 2026-04-13 at 1 07 57 PM
  • it should also auto detect the step of increment/decrement base on cursor position.
    Screenshot 2026-04-13 at 1 13 57 PM
    In this case, it should increment decimal value and not the whole number

Comment thread frontend/src/utils/useNumberInput.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increment/Decrement arrow keys

2 participants