chore: add debug logging before AWS.discover #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug[^1] in the development version of Amazonka, which we have to use to get latest GHC support, that causes `newEnv` to perform a slow DNS lookup, attempting to see if it's being run on an EC2 instance. Since this happens early, before any logging, it can appear our CLIs are stuck for about 30s without any output. And bumping `LOG_LEVEL` doesn't help. Adding a message here will at least provide *some* feedback, while we seek to address this for real. [^1]: brendanhay/amazonka#1018
pbrisbin
requested review from
a team and
joris974
and removed request for
a team
This fixes the slow-down in `discover`: brendanhay/amazonka/#1029.
joelmccracken
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug1 in the development version of Amazonka, which we have
to use to get latest GHC support, that causes
newEnvto perform a slowDNS lookup, attempting to see if it's being run on an EC2 instance.
Since this happens early, before any logging, it can appear our CLIs are
stuck for about 30s without any output. And bumping
LOG_LEVELdoesn'thelp. Adding a message here will at least provide some feedback, while
we seek to address this for real.
Footnotes
https://github.com/brendanhay/amazonka/issues/1018 ↩