Implemented charge windows instead of just picking random low price s… by fredli74 · Pull Request #951 · fredli74/smartcharge-dev

fredli74 · 2026-02-06T01:35:11Z

No description provided.

…egments Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

fredli74 · 2026-02-06T01:38:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4aff26557

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

This pull request implements a sophisticated charge window scheduling algorithm that replaces the simpler approach of just picking random low-price slots. The new system intelligently schedules charge windows by considering price data, time constraints, and multiple competing charge intents (manual, trip, routine, fill) to optimize both cost and charging behavior.

Changes:

Replaced the old GeneratePlan function with a new "soft intents" model that collects all charge requirements first, then schedules them optimally across available price windows
Implemented a greedy sliding-window algorithm to find optimal charge windows that minimize cost while respecting constraints like minimum window duration (to avoid fragmentation in cold weather) and maximum price thresholds
Added support for splitting charge sessions across multiple windows when cost savings justify it, with configurable thresholds for when to split vs. consolidate charging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fredli74 · 2026-02-06T19:11:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 289a128246

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

… quantumMs Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

…ehicle not waking up to charge, cause it though the level was ok already Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


    const locationSettings = this.getVehicleLocationSettings(vehicle, location_uuid);
    const minimum_charge = locationSettings.directLevel;
+    const splitCharge = locationSettings.splitCharge || SplitCharge.Auto;


+          vehicleLog(
+            LogLevel.Trace,
+            vehicle.vehicle_uuid,
+            `scheduleWindows(${scheduleTag}): after step=${stepIndex + 1}/${atomicSteps.length} ` +
+            `${new Date(step.start).toISOString()}..${new Date(step.stop).toISOString()}@${fmtDbPrice(step.price)} ` +
+            `frontier=${frontierSummary(nextStates)} total=${countFrontierNodes(nextStates)} nodesRecorded=${nodesRecorded} ` +
+            `prunedDominated=${nodesPrunedDominated} prunedReplaced=${nodesPrunedReplaced}`
+          );


+  @Field((_type) => String)
+    splitCharge!: SplitCharge | string;


+export function vehicleLog(level: LogLevel, vehicleUUID: string, data: unknown) {
+  if (level <= LOGLEVEL) {
+    const msg = data instanceof Error ? data.message
+      : typeof data === "object" ? JSON.stringify(data)
+      : data;
+    const s = `${new Date().toISOString()} ${logSymbol[level]} ${vehicleUUID} ${msg}`;
+    switch (level) {
+      case LogLevel.Error:
+      case LogLevel.Warning:
+        console.error(s);
+        break;
+      case LogLevel.Info:
+        console.log(s);
+        break;
+      case LogLevel.Debug:
+      case LogLevel.Trace:
+        console.debug(s);
+        break;


Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -85,6 +87,7 @@
              tile
              @input="closedInfo"
            >
+              <!-- eslint-disable-next-line vue/no-v-html -->
              <span v-html="info.message"></span>


+          vehicleLog(
+            LogLevel.Trace,
+            vehicle.vehicle_uuid,
+            `scheduleWindows(${scheduleTag}): after step=${stepIndex + 1}/${atomicSteps.length} ` +
+            `${new Date(step.start).toISOString()}..${new Date(step.stop).toISOString()}@${fmtDbPrice(step.price)} ` +
+            `frontier=${frontierSummary(nextStates)} total=${countFrontierNodes(nextStates)} nodesRecorded=${nodesRecorded} ` +
+            `prunedDominated=${nodesPrunedDominated} prunedReplaced=${nodesPrunedReplaced}`
+          );


…interv�[6D�[K intervals

…ning U�[1D�[K UI feedback.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  return {
    locationID: location_uuid,
    directLevel: DEFAULT_DIRECTLEVEL,
    goal: SmartChargeGoal.Balanced,
+    splitCharge: SplitCharge.Auto,
  };


@@ -90,18 +105,25 @@

  saving!: { [key: string]: boolean };
  goalCBList!: { text: string; value: string }[];
+  splitChargeList!: { text: string; value: string }[];
  data() {
    return {
      saving: {
        directLevel: false,
        goal: false,
+        splitCharge: false,
      },
      goalCBList: [
        { text: "Low cost", value: SmartChargeGoal.Low },
        { text: "Balanced", value: SmartChargeGoal.Balanced },
        { text: "Full charge", value: SmartChargeGoal.Full },
        { text: "Custom", value: "%" },
      ],
+      splitChargeList: [
+        { text: "Never", value: SplitCharge.Never },
+        { text: "Auto", value: SplitCharge.Auto },
+        { text: "Always", value: SplitCharge.Always },
+      ],


+  get splitCharge(): string {
+    return this.settings.splitCharge || SplitCharge.Auto;
+  }


            {
              locationID: this.settings.locationID,
              directLevel: this.settings.directLevel,
              goal: goal.value || goal,
+              splitCharge: this.settings.splitCharge || SplitCharge.Auto,
            } as GQLVehicleLocationSetting,


+          vehicleLog(
+            LogLevel.Trace,
+            vehicle.vehicle_uuid,
+            `scheduleWindows(${scheduleTag}): after step=${stepIndex + 1}/${atomicSteps.length} ` +
+            `${new Date(step.start).toISOString()}..${new Date(step.stop).toISOString()}@${fmtDbPrice(step.price)} ` +
+            `frontier=${frontierSummary(nextStates)} total=${countFrontierNodes(nextStates)} nodesRecorded=${nodesRecorded} ` +
+            `prunedDominated=${nodesPrunedDominated} prunedReplaced=${nodesPrunedReplaced}`
+          );
+          states = nextStates;
+        }
+


Implemented charge windows instead of just picking random low price s…

f4aff26

…egments Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

fredli74 requested a review from Copilot February 6, 2026 01:35

Copilot started reviewing on behalf of fredli74 February 6, 2026 01:35 View session

chatgpt-codex-connector Bot reviewed Feb 6, 2026

View reviewed changes

Comment thread server/logic.ts Outdated

Comment thread server/logic.ts Outdated

Copilot AI reviewed Feb 6, 2026

View reviewed changes

fredli74 and others added 6 commits February 6, 2026 02:46

logic.ts trailing whitespace

f0cabe5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update server/logic.ts

6ee0dd7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Reuse now instead of Date.now()

d77163b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Incorrectly removed current timeslot from price_data SQL

62ca0a6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Inline score calculation for remainders.

2f49ce8

Track requested charge levels in status messages

56f2dbf

Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

fredli74 requested a review from Copilot February 6, 2026 02:08

Copilot started reviewing on behalf of fredli74 February 6, 2026 02:08 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Comment thread server/logic.ts Outdated

fredli74 added 2 commits February 6, 2026 20:00

Refactor soft intents: type definition and status function

dfdbcbc

Disable ESLint for v-html in alerts

289a128

fredli74 requested a review from Copilot February 6, 2026 19:10

Copilot started reviewing on behalf of fredli74 February 6, 2026 19:10 View session

chatgpt-codex-connector Bot reviewed Feb 6, 2026

View reviewed changes

Comment thread server/logic.ts Outdated

Comment thread server/logic.ts Outdated

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Comment thread server/logic.ts Outdated

Comment thread app/src/app.vue

Comment thread app/src/app.vue

Comment thread app/src/app.vue

Comment thread server/logic.ts

fredli74 added 4 commits February 7, 2026 02:35

Still do SoftIntents during manual charge, because of trip scheduling

edee93d

Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

Fix backoff logic to always run at least once if we have a targetMs <…

cd6e37c

… quantumMs Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

Fix: Apply fill plan only if windows exist and time sufficient

a05c30e

Tesla-agent would set charge limit (wantedSoc) too low and risk the v…

9970b35

…ehicle not waking up to charge, cause it though the level was ok already Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

fredli74 requested a review from Copilot February 7, 2026 01:51

Copilot started reviewing on behalf of fredli74 February 7, 2026 01:52 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

Comment thread app/src/app.vue

Comment thread app/src/app.vue

Improve logging

abaa689

Signed-off-by: Fredrik Lidström <fredli74@gmail.com>

fredli74 requested a review from Copilot April 22, 2026 01:29

Copilot started reviewing on behalf of fredli74 April 22, 2026 01:30 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

fredli74 added 9 commits April 22, 2026 10:12

Refactor log formatting into helper function

26458af

Fix: Sort schedules by start time instead of stop time

c767ffe

Sort intents by start time instead of stop time.

770145f

Enhance schedule management and emergency wake-up logic

ea2929b

Update manual schedule departure threshold to 3km for clearer detection.

c24027f

Remove setSmartStatusFromIntent and integrate status into charge plan

44b1f35

Log VIN always, include UUID when available

ae599de

Move Tesla scheduling methods to public utilities.

2c474af

Add Node.js tests for Tesla agent logic

c2b0854

fredli74 requested a review from Copilot April 22, 2026 14:08

Copilot started reviewing on behalf of fredli74 April 22, 2026 14:08 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

fredli74 added 11 commits April 22, 2026 18:15

Add trusted HTML comments to v-html usages

40e31e0

Replace splitCharge string with enum in resolvers and schema

df20a04

Refactor charge schedule quantum and adjust blocker logic for tariff …

562a1fe

…interv�[6D�[K intervals

Fix emergency wake-up time parsing and log formatting

79979ac

Fix: Skip schedule reconciliation if live schedules are unknown

f49c50e

Add schedule sync issue indicators and backend support

7acb956

Simplify schedule sync issue handling by removing reason and streamli…

868024c

…ning U�[1D�[K UI feedback.

Update sync status colors and drift message wording

060e327

Move icon class to tooltip activator

7c89cc2

Use issueKind instead of hardcoded 'drift

c0de92a

Update schedule tooltip and add SOC limit checks

0eb6648

fredli74 requested a review from Copilot April 25, 2026 17:59

Copilot started reviewing on behalf of fredli74 April 25, 2026 18:00 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Fix schedule sync classification by checking start time only.

8e21af4

		@Field((_type) => String)
		splitCharge!: SplitCharge \| string;

Conversation

fredli74 commented Feb 6, 2026

Uh oh!

fredli74 commented Feb 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

fredli74 commented Feb 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants