test/docs: document and expand test coverage for connection priority and retries#491
Merged
Conversation
cachebag
requested changes
Jul 10, 2026
Contributor
Author
Thanks for the links to the official specification and the thorough review! Pushed the fixes! |
cachebag
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation and adds additional tests for
ConnectionOptions, particularly forautoconnect_priorityandautoconnect_retries.Although the implementation was already in place, the documentation needed clarification to better match NetworkManager's specifications. The test suite has also been expanded to cover boundary values, providing better confidence that the mapping behaves as expected.
Closes #218