fix(#485): only output visible SSIDs#494
Merged
Merged
Conversation
…be shown when called by wifi_groups()
cachebag
approved these changes
Jul 12, 2026
cachebag
left a comment
cachebag
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. There are several cases where we might want to show a hidden network but the semantics around when and how are best reserved for a follow up issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to Issue #485 , based on documentation in wifi-per-device.md the expected output of NetworkSnapshot::wifi_groups() is only visible networks. The function was updated to only output the visible networks and is confirmed with a new test. In addition /api/models.md was updated to be consistent with this new functionality.
If any additional changes are needed I'd be happy to work on providing them here.
Closes #485