Skip to content

refactor(#495): method to discover hidden networks (opt-in)#496

Open
justinjest wants to merge 3 commits into
freedesktop-rs:masterfrom
justinjest:issue_495
Open

refactor(#495): method to discover hidden networks (opt-in)#496
justinjest wants to merge 3 commits into
freedesktop-rs:masterfrom
justinjest:issue_495

Conversation

@justinjest

Copy link
Copy Markdown
Contributor

A minor refactor to address issue #495. I believe this will make hidden ap's available, and should now hide them by default. If we wanted to also handle the parsing of the hidden ap's names I can work on that next, however I believe that is out of the scope of this issue.

I addressed some of the examples to show that all_wifi_groups are available; however I did not add them to many examples that did not use them directly.

@cachebag cachebag left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your contributions- could you just read the contribution guidelines and make sure you follow things like the commit message hygiene? You should also reference the issue you are closing in your PR description (i.e. "Closes #495" so that it properly links the issue as being closed by this PR once merged).

pub wifi_groups: Vec<WifiNetworkGroup>,
/// All Wi-Fi groups keyed by interface and SSID.
pub all_wifi_groups: Vec<WifiNetworkGroup>,
/// Saved Wi-Fi profiles keyed by SSID.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't yet know how I feel about breaking the current shape of AppletNetworkSummary...I am at work but will think on this more soon. Surely, there is a better way to approach this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking into this more and I've found a way to preserve the api by creating a similar structure for applet_summary as I used for wifi_groups. This would enable users to determine which they want and keep the same api bindings for both, but would require different function calls to receive hidden ap's in both cases. If there are any other ideas I'm happy to explore them as well, but if this sounds like a possible solution I can send it up for your review.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah I was thinking something similar.

Happy to review these changes whenever you'd like to add them.

@cachebag cachebag added api-surface Public API design, re-exports, and semver-relevant changes refactor Change or improve code wifi WiFi connection management labels Jul 13, 2026
@cachebag cachebag changed the title Issue 495 refactor(#495): method to discover hidden networks (opt-in) Jul 13, 2026
@justinjest

Copy link
Copy Markdown
Contributor Author

I'll make sure to include the issue number in the commits in the future and be clearer about the connections to the issue's in my PR's. I apologize for the inconvenience this has caused and will be more mindful in the future.

@justinjest justinjest requested a review from cachebag July 14, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-surface Public API design, re-exports, and semver-relevant changes refactor Change or improve code wifi WiFi connection management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants