Merged
Conversation
Owner
freezy
commented
Apr 20, 2025
- Fix spelling errors in doc
- Remove locked status from drag points
- Make asset lib paths configurable
- Fix tri stats in asset browser
- Make camera orbit script more configurable with better defaults
- Fix trigger creation for flipper correction feature.
- Fix UV mapping for ramps and surfaces.
…orrection triggers, and properly render gizmos during gameplay.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances quality of life by addressing documentation spelling errors, removing drag point locking, making asset library paths configurable, and refining several physics and graphics behaviors. Key changes include:
- Removal of the IsLocked property from drag point data and related editor functionality.
- Updates to collider setup and transformation logic for improved configurability.
- Adjustments to asset library path handling and thumbnail lookup across the editor.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| VisualPinball.Unity/VPT/Flipper/FlipperComponent.cs | Uses a rotated matrix for flipper transformation; sets TriggerItemId for trigger components. |
| VisualPinball.Unity/VPT/Flipper/FlipperColliderComponent.cs | Exposes TriggerItemId to support flipper correction. |
| VisualPinball.Unity/VPT/ColliderComponent.cs | Refactors collider caching and transformation logic; removes separate kinematic collider mesh references. |
| VisualPinball.Unity/Physics/NativeColliders.cs | Improves exception messages by including colliderId. |
| CommonPackables.cs, DragPoint* files, DragPointData.cs | Removes references to locked state for drag points. |
| Various AssetBrowser and AssetLibrary files | Updates thumbnail and asset meta path resolution using configurable library paths. |
| CameraTranslateAndOrbit.cs | Introduces configurable pan, orbit and smoothing parameters with updated transform cache usage. |
| Documentation~/creators-guide/editor/asset-library-styleguide.md | Fixes minor typos for clarity. |
Comments suppressed due to low confidence (1)
VisualPinball.Unity/VisualPinball.Unity/VPT/ColliderComponent.cs:324
- Replacing the previously passed transformation matrix with float4x4.identity may affect the intended positioning of colliders. Verify that using the identity matrix here preserves the correct collider alignment.
api.CreateColliders(ref colliders, float4x4.identity, 0.1f);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.