Fix: Implement data aggregation for community node count (#53)#54
Open
charanbhatia wants to merge 1 commit intofreifunk:masterfrom
Open
Fix: Implement data aggregation for community node count (#53)#54charanbhatia wants to merge 1 commit intofreifunk:masterfrom
charanbhatia wants to merge 1 commit intofreifunk:masterfrom
Conversation
andibraeu
requested changes
Aug 19, 2024
| #### Option 1: Using MongoDB Shell (mongosh) | ||
|
|
||
| ```bash | ||
| mongosh mongodb+srv://databaseReader:freifunkfreifunk@freifunktest.zsfzlav.mongodb.net/ |
Member
There was a problem hiding this comment.
please do not publish secrets here!
Member
There was a problem hiding this comment.
Instead of publishing secrets and database connection strings, where usage could lead to potential high costs, we should show how to setup a mongodb via docker compose.
Member
There was a problem hiding this comment.
and of course show how to import data (we could provide a sample dataset)
| For a more user-friendly interface, use MongoDB Compass with the same connection string: | ||
|
|
||
| ``` | ||
| mongodb+srv://databaseReader:freifunkfreifunk@freifunktest.zsfzlav.mongodb.net/ |
Member
There was a problem hiding this comment.
please do not publish secrets here!
Member
|
hey @charanbhatia thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #53 by implementing a new data aggregation feature for community node counts.
Changes made:
graphql_server/mongodb_queries/community_node_count.jsgraphql_server/server.jsfor the community node count querygraphql_server/schema.jsto include the new query typevisualisations/graphs/community_node_count_graph.jsvisualisations/index.htmlto include the new graphTo test:
communityNodeCountqueryThis PR closes #53.
Please review and let me know if any changes are needed.