Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
enddynayn
force-pushed
the
feat/add-bridging-to-testnet
branch
2 times, most recently
from
f154890 to
d9bd824
Compare
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
Need to update the spec version
enddynayn
force-pushed
the
feat/add-bridging-to-testnet
branch
from
ae7bda2 to
eab7620
Compare
enddynayn
changed the title
Enables the frequency-bridging feature for testnet.
enddynayn
force-pushed
the
feat/add-bridging-to-testnet
branch
from
eab7620 to
17e6c80
Compare
github-actions
bot
added
the
metadata-changed
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
- I reviewed the code changes.
- @enddynayn answered my questions in slack.
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
I'll looked into it but to be honest I don't have enough context to know if something is missing or not to enable the bridging.
| frequency-no-relay = ["frequency-service/frequency-no-relay"] | ||
| frequency-local = ["frequency-service/frequency-local"] | ||
| frequency-testnet = ["frequency-service/frequency-testnet"] | ||
| frequency-testnet = ["frequency-service/frequency-testnet", "frequency-bridging"] |
There was a problem hiding this comment.
is this going to work on paseo? As long as I remember Paseo couldn't do xcm and that's why we were doing Westend integrations?
There was a problem hiding this comment.
Feel free to ignore my comment since that might be just for the snowbridge and I might be mixing it with Polkadot
There was a problem hiding this comment.
Paseo can do XCM, it's required for Coretime, and required for us to renew our coretime and turn on auto-renew
| pub use weights::*; | ||
|
|
||
| /// Offchain storage for MSA pallet | ||
| #[cfg(not(feature = "no-custom-host-functions"))] |
There was a problem hiding this comment.
Why are these removed from here but we still have it in other places in the codebase? It appears that @JoeCap08055 added this feature flag
There was a problem hiding this comment.
If we are not using that feature flag, why are we removing these?
There was a problem hiding this comment.
It was not compiling it. I pair with @JoeCap08055 on this.
There was a problem hiding this comment.
These were added during PR review of my PR, but apparently was over-zealous: we actually do not want to selectively disable these lines, as they cause compilation failure if this feature flag is enabled. Didn't catch it in the previous PR because CI doesn't compile with that feature flag; it's only for local dev.
4 participants
Enables the frequency-bridging feature for testnet.