feat: add PayloadLocation::OffChain enum variant#2678
Open
JoeCap08055 wants to merge 3 commits intomainfrom
Open
feat: add PayloadLocation::OffChain enum variant#2678JoeCap08055 wants to merge 3 commits intomainfrom
JoeCap08055 wants to merge 3 commits intomainfrom
Conversation
JoeCap08055
requested review from
a team and
enddynayn
and removed request for
a team
JoeCap08055
commented
Mar 19, 2026
Comment on lines
+73
to
+74
| /// Message payload is located off-chain, other than IPFS | ||
| OffChain, |
Collaborator
Author
There was a problem hiding this comment.
This and the spec version bump are the only runtime code changes; everything else is just updating unit and E2E tests.
enddynayn
approved these changes
Mar 19, 2026
shannonwells
approved these changes
Mar 19, 2026
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
I reviewed the code, good test changes etc. Looks good!
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
github-actions
bot
added
the
metadata-changed
github-actions
bot
added
metadata-changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to add an enum variant,
PayloadLocation::OffChainto better represent Intents and Schemas for which data is stored off-chain, but not specifically on IPFS.Closes #2677
Checklist