Catch and log transform errors in the GrpcStreamBroadcaster#203
Merged
shsms merged 3 commits intofrequenz-floss:v0.x.xfrom Dec 18, 2025
Merged
Catch and log transform errors in the GrpcStreamBroadcaster#203shsms merged 3 commits intofrequenz-floss:v0.x.xfrom
shsms merged 3 commits intofrequenz-floss:v0.x.xfrom
Conversation
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
There was a problem hiding this comment.
Pull request overview
This PR adds error handling to the GrpcStreamBroadcaster to catch and log exceptions raised by the transform method, preventing the entire stream from failing when individual message transformations fail.
- Added try-except block around the transform call to catch exceptions and log them
- Messages that fail transformation are now skipped (using continue) so the stream continues processing subsequent messages
- Added comprehensive test coverage for transform errors
- Added
@overridedecorators to retry strategy implementations for better type safety
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/frequenz/client/base/streaming.py | Added exception handling around the transform call to catch, log, and skip messages that fail transformation |
| tests/streaming/test_grpc_stream_broadcaster.py | Added test case to verify transform errors are caught, logged, and don't break the stream |
| src/frequenz/client/base/retry.py | Added @override decorators to next_interval methods in retry strategy classes |
| RELEASE_NOTES.md | Documented the bug fix for transform error handling |
Comments suppressed due to low confidence (1)
tests/streaming/test_grpc_stream_broadcaster.py:304
- Variable error is not used.
def transform_err(x: int) -> str:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also add tests Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
cwasicki
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.